Skip to content

feat(mentoring): A skill and an agent in order to help juniors in their work by understanding result and by teaching them#825

Merged
aaronpowell merged 1 commit intogithub:stagedfrom
fdescamps:feature/add-mentor-skill
Mar 2, 2026
Merged

feat(mentoring): A skill and an agent in order to help juniors in their work by understanding result and by teaching them#825
aaronpowell merged 1 commit intogithub:stagedfrom
fdescamps:feature/add-mentor-skill

Conversation

@fdescamps
Copy link
Copy Markdown
Contributor

@fdescamps fdescamps commented Feb 26, 2026

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • My contribution adds a new instruction, prompt, agent, skill, or workflow file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, or workflow with GitHub Copilot.
  • I have run npm run build and verified that README.md is up to date.

Description

This PR adds a new mentoring-juniors skill and its companion agent to help junior developers learn and improve their coding practices through Socratic mentorship.

Skill: skills/mentoring-juniors/

The skill provides a comprehensive Socratic mentoring methodology:

  • Sensei persona — A patient, experienced mentor who guides through questions
  • PEAR Loop — Plan, Explore, Analyze, Rewrite workflow for Copilot-assisted learning
  • Progressive clue system — 4-level help from guided questions to detailed pseudocode
  • 5-phase response protocol — Context → Socratic Questions → Concepts → Clues → Validation
  • Teaching techniques — Rubber Duck Debugging, 5 Whys, Red-Green-Refactor
  • 47 trigger keywords — Covers common junior expressions (I'm stuck, help me understand, ELI5, etc.)

Agent: agents/mentoring-juniors.agent.md

A companion agent that brings the same Socratic methodology directly into GitHub Copilot Chat:

  • Model: gpt-4.1
  • Tools: codebase, search, problems, editFiles, usages, and more
  • Invocation: @Sensei - Junior Mentor in Copilot Chat
  • Same persona, golden rules, and response protocol as the skill

Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • Update to existing instruction, prompt, agent, plugin, skill, or workflow.
  • Other (please specify):

Additional Notes

  • Skill folder: skills/mentoring-juniors/
  • Agent file: agents/mentoring-juniors.agent.md
  • Validation: Passed npm run skill:validate
  • README: Updated with npm run build
  • Line endings: Normalized with bash scripts/fix-line-endings.sh
  • Authors: Thomas Chmara (@AGAH4X) & François Descamps (@fdescamps)

By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@fdescamps fdescamps force-pushed the feature/add-mentor-skill branch from 3f3c4e9 to 8a77907 Compare February 26, 2026 15:02
@github-actions github-actions Bot force-pushed the main branch 2 times, most recently from b4006f0 to 10eb844 Compare February 26, 2026 23:21
@aaronpowell aaronpowell changed the base branch from main to staged February 26, 2026 23:22
aaronpowell
aaronpowell requested changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you've branched off the main branch, not staged meaning you have all the materialised plugin files.

You can fix this with:

git fetch origin staged
git rebase --onto origin/staged origin/main <your branch name>
git push --force-with-lease

Or by using the script npm run plugin:clean

@fdescamps fdescamps force-pushed the feature/add-mentor-skill branch 2 times, most recently from aa35aa3 to 474714d Compare February 27, 2026 12:24
@fdescamps fdescamps force-pushed the feature/add-mentor-skill branch 2 times, most recently from 33d275c to 7853661 Compare February 27, 2026 13:20
aaronpowell
aaronpowell requested changes Mar 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we've got some spelling issues picked up, and npm run build needs to be run to ensure that all the README files are up to date.

@fdescamps fdescamps force-pushed the feature/add-mentor-skill branch from 7853661 to fd77431 Compare March 2, 2026 06:30
@fdescamps
Copy link
Copy Markdown
Contributor Author

fdescamps commented Mar 2, 2026

Hum, thanks @aaronpowell !

Do you want me to correct the code spell issue ?
My point is : in fact it was voluntary words to catch different way for junior to express themselves in the chat

@aaronpowell
Copy link
Copy Markdown
Contributor

aaronpowell commented Mar 2, 2026

Let's correct the issues. I understand the intent that you're going for here, but AI models are pretty solid when it comes to correcting terrible English spelling and grammar, so even if someone said "doesnt" the model would still determine that it matches "doesn't"

@fdescamps fdescamps force-pushed the feature/add-mentor-skill branch 3 times, most recently from 01b38bb to caeb4ea Compare March 2, 2026 15:13
@fdescamps
feat: add mentoring-juniors skill for Socratic mentoring methodology
6eea279 
feat: add Sensei Socratic mentor for junior developers

feat: add Sensei Junior Mentor skill for Socratic mentoring of junior developers
@fdescamps fdescamps force-pushed the feature/add-mentor-skill branch from caeb4ea to 6eea279 Compare March 2, 2026 15:20
@fdescamps
Copy link
Copy Markdown
Contributor Author

fdescamps commented Mar 2, 2026 •
edited
Loading

Let's correct the issues. I understand the intent that you're going for here, but AI models are pretty solid when it comes to correcting terrible English spelling and grammar, so even if someone said "doesnt" the model would still determine that it matches "doesn't"

Hello, yes, it makes sense @aaronpowell
It's corrected ;)

Thanks,

@aaronpowell aaronpowell merged commit 306a2d3 into github:staged Mar 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronpowell aaronpowell aaronpowell approved these changes

+7 more reviewers

@SebastienDegodez SebastienDegodez SebastienDegodez approved these changes

@Debaerdm Debaerdm Debaerdm approved these changes

@AlexisLambois AlexisLambois AlexisLambois approved these changes

@BaDk23 BaDk23 BaDk23 approved these changes

@AGAH4X AGAH4X AGAH4X approved these changes

@MqtCorentin MqtCorentin MqtCorentin approved these changes

@Erwatt2 Erwatt2 Erwatt2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@fdescamps @aaronpowell @SebastienDegodez @Debaerdm @AlexisLambois @BaDk23 @AGAH4X @MqtCorentin @Erwatt2